Gracefully handle NotSupportedError during schema introspection#696
Open
gavinhodge wants to merge 1 commit intoexplorerhq:masterfrom
Open
Gracefully handle NotSupportedError during schema introspection#696gavinhodge wants to merge 1 commit intoexplorerhq:masterfrom
gavinhodge wants to merge 1 commit intoexplorerhq:masterfrom
Conversation
Author
|
Hi maintainers, does this need any action from my end before it can be reviewed or merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain circumstances, a django.db.utils.NotSupportedError can be thrown during schema introspection. If this happens, the exception is unhandled and Django returns a 500 response instead of displaying query results.
To reproduce requires:
ALTER TABLE table_name SET UNLOGGED)SELECT 1) against the standby server and receive a 500 error pageException detail:
The issue can be worked around by specifying the affected tables in the
EXPLORER_SCHEMA_EXCLUDE_TABLE_PREFIXESsetting, but this change makes a workaround unnecessary.